Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Implement hit detection for WebGL Mapbox Vector Tiles #15442

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

gberaudo
Copy link
Member

@gberaudo gberaudo commented Dec 19, 2023

This PR implements hit detection in the MVT WebGL renderer.
This is achieved by using the same technique has for the vector layer renderer, with some additionnal bits to handle the tiles.

This is an early PR (WIP) to share the current state of the work.

For testing, use http://localhost:8080/webgl-vector-tiles.html
This test has been modified to display the selected feature with a different styling, in a separate layer.

To investigate / fix:

  • points does not seem to work;
  • white countries polygons does not match anything (maybe OK: do the actually exist as features?);
  • why only initial zoom level works?
  • figure out the issue with Feature/RenderFeature type mismatch in TileGeometry.js;
  • update the test to account for the additionnal low-level calls due to hit detection;

Copy link

📦 Preview the website for this branch here: https://deploy-preview-15442--ol-site.netlify.app/.

@gberaudo
Copy link
Member Author

Hit detection framebuffer looks correct, whatever the zoom level:
image

image

@jahow
Copy link
Contributor

jahow commented Dec 19, 2023

* [ ]  white countries polygons does not match anything (maybe OK: do the actually exist as features?);

In these tiles the countries are not polygons; the water bodies are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants