Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert Mapbox Streets V6 example style to flat format #15413

Draft
wants to merge 12 commits into
base: main
Choose a base branch
from
Draft

Convert Mapbox Streets V6 example style to flat format #15413

wants to merge 12 commits into from

Commits on Dec 8, 2023

  1. Implement geometry-type operator in cpu

    @jahow
    jahow committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    adeb884 View commit details
    Browse the repository at this point in the history

  2. Allow evaluating expressions on CPU with missing inputs 

    Evaluation contexts are now initialized with every properties set to
UNKNOWN_VALUE.

If an expression needs an input which is unknown, it will return UNKNOWN_VALUE.
    @jahow
    jahow committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    895e1b9 View commit details
    Browse the repository at this point in the history

  3. Cleanup incorrect comment

    @jahow
    jahow committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    b2e40c5 View commit details
    Browse the repository at this point in the history

  4. Add a filter() method to MixedGeometryBatch 

    This will be used to filter out features that will eventually be rendered
    @jahow
    jahow committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    630002d View commit details
    Browse the repository at this point in the history

  5. WebGL / Use style filter when generating buffers

    @jahow
    jahow committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    3bef70a View commit details
    Browse the repository at this point in the history

  6. WebGL / the gpu compiler will now take into account props and variabl… 

    …e types

Previously the style parser was having this responsibility. Now reading from
feature attributes and style variables is done in the gpu compiler logic
    @jahow
    jahow committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    0d7ec7e View commit details
    Browse the repository at this point in the history

  7. WebGL / use a specific constant when a prop or var is not defined 

    This avoids a crash if a prop or var is not defined at runtime
    @jahow
    jahow committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    c810592 View commit details
    Browse the repository at this point in the history

  8. Convert MapboxStreetsV6 format to expression-based 

    This required compiling all the maki icons to a spritesheet
Done using https://github.com/flother/spreet

The MapboxStreetsV6 style was converted with partial automation
    @jahow
    jahow committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    4d4abbb View commit details
    Browse the repository at this point in the history

  9. Allow dynamic name for var and get operators 

    This was also taken into account for the cpu and gpu compilers.

The GPU compiler uses the CPU compiler to evaluate var/get names at compile
time
    @jahow
    jahow committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    948e4d0 View commit details
    Browse the repository at this point in the history

  10. WebGL / add support for concat operator on gpu 

    This operator is evaluated on the CPU at compile time, which means that it
won't have access to runtime values (feature props, variables etc.)
    @jahow
    jahow committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    89fb58d View commit details
    Browse the repository at this point in the history

  11. wip better support for dynamic name expressions in get/var

    @jahow
    jahow committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    e6bee20 View commit details
    Browse the repository at this point in the history

  12. wip make concat more lenient on cpu

    @jahow
    jahow committed Dec 8, 2023
    Configuration menu
    Copy the full SHA
    0cff7be View commit details
    Browse the repository at this point in the history