Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch to WebGL 2.0 #15136

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

gberaudo
Copy link
Member

@gberaudo gberaudo commented Sep 14, 2023

As discussed during the OL code sprint in Munich, we would like to move our code base to WebGL2.

This will allow us to write cleaner and more performant code, thanks to the new rendering techniques introduced in this new version.

Closes: #14377
Closes: #14366
Closes: #13367

@github-actions
Copy link

📦 Preview the website for this branch here: https://deploy-preview-15136--ol-site.netlify.app/.

@mike-000
Copy link
Contributor

Without a fallback as in #14366/#14377 this will break all existing WebGL functionality on Chrome and Edge on many Windows 10 systems (especially those which have been upgraded from Windows 7).

@jahow
Copy link
Contributor

jahow commented Sep 14, 2023

@mike-000 could you please indicate where you get that data from? https://caniuse.com/webgl2 shows all green for chrome and edge (albeit with a slightly lower compatibility of 93% instead of 95% for webgl1).

Edit: looks like Three.js will be dropping webgl1 support soon. Maplibre has also moved to webgl2 but still includes a fallback to webgl1. This thread is interesting: maplibre/maplibre-gl-js#2653

@mike-000
Copy link
Contributor

@jahow As in #14366 (comment) it is not a problem of browser support, it is Chrome and Edge will not work with older hardware (even though Firefox will work with it) so support for a WebGL fallback would be needed until October 2025 (I presume all Windows 11 compatible systems will be OK). Both of my ex Windows 7 systems have the same issue, while an ex Windows 8 system has no problem.

image

@tschaub
Copy link
Member

tschaub commented Sep 15, 2023

When we want to move to WebGL 2, the Canvas renderer provides an alternative for people who want to support older hardware.

@mike-000
Copy link
Contributor

There is no problem requiring WebGL2 for new functionality which is currently experimental. Supporting only WebGL2 will break existing API functionality such as WebGL tile and Heatmap on the default browsers of many Windows 10 systems which still have 2 years support. The only alternative to ensure compatibility will be to not upgrade to newer OpenLayers versions or switch to alternative platforms.

@tschaub
Copy link
Member

tschaub commented Sep 15, 2023

Yes, when we decide to do this, it will be in a major version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for WebGL2
4 participants