-
Notifications
You must be signed in to change notification settings - Fork 437
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8329821: [Linux] When using i3 WM, menus are incorrectly sized #1437
Conversation
👋 Welcome back tsayao! A progress list of the required criteria for merging this PR into |
@tsayao This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 49 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
High chance it's the same problem. |
So I can reproduce this on my system now and could potentially test this PR. How would one go about this, testing a specific PR? |
You will need to checkout the PR branch and build JavaFX from source. See the "Using git" instructions added by Skara in the "Reviewing" section of this PR's Description for how to fetch and checkout this PR branch. See the build instructions Wiki page for instructions on building JavaFX. |
I could verify that this change fixes the issue with i3 window manager. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, tested with and without fix, with and without i3 window manager.
/integrate |
Going to push as commit a7627fa.
Your commit was automatically rebased without conflicts. |
Simple fix to only request
_NET_FRAME_EXTENTS
if window has decoration.It seems i3 replies with decorated sizes, even if window is not decorated.
Won't hurt other WMs.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1437/head:pull/1437
$ git checkout pull/1437
Update a local copy of the PR:
$ git checkout pull/1437
$ git pull https://git.openjdk.org/jfx.git pull/1437/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1437
View PR using the GUI difftool:
$ git pr show -t 1437
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1437.diff
Webrev
Link to Webrev Comment