Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314968: Public InputMap #1395

Draft
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

andy-goryachev-oracle
Copy link
Contributor

@andy-goryachev-oracle andy-goryachev-oracle commented Mar 8, 2024

Summary

Add the InputMap property in the Control class which enables customization of controls with the application key mappings and event handlers, and to guarantee specific order of event handlers invocation and priority of application mappings over those created by the skin.

Add SkinInputMap and optional BehaviorBase classes to simplify creation of skins for existing and new controls.

Goals

The goals of this proposal are:

  • allow for customization of a control behavior by changing the existing or adding new key mappings
  • support dynamic modification of key mappings
  • allow for accessing the default functionality even when it was overwritten by the application
  • allow for reverting customization to the default implementation
  • guarantee priorities between the application and the skin event handlers and key mappings
  • allow for gradual migration of the existing controls to use the new InputMap
  • support stateful and stateless (fully static) behavior implementations

Non-Goals

It is not the goal of this proposal:

  • to require specific base class for the behavior implementations
  • to allow for complete decoupling of the skin from the behavior
  • to make the legacy internal InputMap class public
  • to make existing core behaviors public

Complete proposal:
https://github.com/andy-goryachev-oracle/Test/blob/main/doc/InputMap/InputMapV2.md


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires a CSR request matching fixVersion jfx23 to be approved (needs to be created)

Issue

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jfx.git pull/1395/head:pull/1395
$ git checkout pull/1395

Update a local copy of the PR:
$ git checkout pull/1395
$ git pull https://git.openjdk.org/jfx.git pull/1395/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1395

View PR using the GUI difftool:
$ git pr show -t 1395

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jfx/pull/1395.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Mar 8, 2024

👋 Welcome back angorya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@andy-goryachev-oracle
Copy link
Contributor Author

/csr

@openjdk openjdk bot added the csr Need approved CSR to integrate pull request label Mar 8, 2024
@openjdk
Copy link

openjdk bot commented Mar 8, 2024

@andy-goryachev-oracle has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@andy-goryachev-oracle please create a CSR request for issue JDK-8314968 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

@openjdk
Copy link

openjdk bot commented Mar 13, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@bridgekeeper
Copy link

bridgekeeper bot commented May 9, 2024

@andy-goryachev-oracle This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@andy-goryachev-oracle
Copy link
Contributor Author

keep alive

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
csr Need approved CSR to integrate pull request
1 participant