Kotlin version of app demo #656
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Motivation and Context
Kotlin is an officially supported language for Android app development but, there is only a Java version of the demo. With the Android Studio, it is possible to automatically convert the Java code, but the resulting code needs additional work to compile and run correctly. This commit cuts the step to convert Java to Kotlin every time someone wants to have a Kotlin version.
Description
This commit adds a Kotlin version of the demo app based on the Java version. It also uses view binding. However, it does not have the browser selection feature because replacing AsyncTask with Kotlin Coroutines is nontrivial.