2001pull #1057
Open
2001pull #1057
+14,134
−4,380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add note about gradle check target in contribution guidelines.
Signed-off-by: Mohamed Ezzat <mohamed.ezzat@devfactory.com>
…-improvements-fix-1 Multiple quality improvements
…tion.fromJson(). Fixes openid#88: since the registration endpoint is not required by the spec, it might not be set when trying to deserialize a serialized representation.
Whether we have a refresh token or not is irrelevant for determining if the access token is valid. The case where the access token has expired and we have no refresh token is already signalled as an error to the callback in performActionWithFreshTokens.
Fix for issue openid#88: handle missing registration endpoint
The gradle build files were getting pretty ugly, so this CL breaks them up into manageable, reusable chunks. While doing this, tool and library dependencies have been updated to the latest versions, enabling the use of vector drawables (to get rid of the various DPI versions of the icons used in the demo app). Finally, I switched from Picasso to Glide, which is the current recommended image loader library within Google.
Dependency updates, gradle file cleanup and vector drawables them up into manageable, reusable chunks. While doing this, tool and library dependencies have been updated to the latest versions, enabling the use of vector drawables (to get rid of the various DPI versions of the icons used in the demo app). Finally, I switched from Picasso to Glide, which is the current recommended image loader library within Google.
Disregard refresh token when deciding if access token is still fresh. if the access token is valid. The case where the access token has expired and we have no refresh token is already signalled as an error to the callback in performActionWithFreshTokens.
Disable old library version checks; we periodically update these manually.
Also fixes showVersion build rule
The guidelines for using robolectric have changed; by replacing RobolectricGradleTestRunner with RobolectricTestRunner, all tests now pass again.
This change fixes issues openid#106, openid#104 and openid#102. activity via an Intent with using SINGLE_TOP | CLEAR_TOP, we can dispose of the browser tab without using the NO_HISTORY flag. The browser flow will survive the user switching tasks, and will not appear in the back stack after the authorization flow completes. as instance state on the activity. If the activity is completely killed under memory pressure during the authorization flow, everything should still work as intended once the application's activities are restored. This removes the need for PendingIntentStore, which was using a static map to store this information previously. when this is resumed without receiving the redirect from the authorization flow in the browser. This is a signal that the user canceled the flow by pressing the back button or closing the tab. Based on this, we can fire a different PendingIntent to indicate the flow was canceled. The changes *should* be backwards compatible. We have also simplified the configuration of the redirect URI receiver activity, using a manifest merge attribute set in the build file.
Support for login_hint parameter
Use an intermediary activity to manage the authorization flow
Failing to check the state was a regression introduced by the change from using a static store of requests to the AuthorizationManagementActivity - this is now corrected, with tests added.
This gives apps more control over the browsers that can be used for the authorization flow. Fixes openid#116, openid#114, openid#113.
This allows a number of use cases: - Disabling HTTPS checks for debug environments - Configuring certificate pinning - Using a different HTTP stack, such as okhttp or cronet Fixes openid#115.
This change adds the ability to explicitly choose the browser to use in the demo app, making it easier to test the authorization flow against specific browsers. This uncovered an issue in AuthorizationManagementActivity when using a standalone browser: - launchMode=singleTask is required to ensure that the correct activity instance is reached. This also has the side effect that only one browser-based interaction can happen at a time, but this is a reasonable assumption for the library to make. - Failing to find stored state for handling a redirect no longer causes an IllegalStateException, and instead simply finishes the management activity. This can happen where the user switches back and forth between the app and browser, resulting in the flow being cancelled and then resumed after the state is lost.
line 55: an -> a
Fix auth_config file path in LoginActivity comment [skip ci]
…enid#769) On Android 12 onResume is called before onNewIntent on configChanges breaking the authentication flow which ends up in user cancellation.
fabio3dfx
suggested changes
May 10, 2024
| @@ -0,0 +1,9 @@ | |||
| root = true | |||
fabio3dfx
approved these changes
May 10, 2024
| @@ -0,0 +1,24 @@ | |||
| --- | |||
There was a problem hiding this comment.
Eu estou sendo vigiado por um usuário? Não dei autorização pra tal evento.
fabio3dfx
reviewed
May 10, 2024
| [*.{java,xml,gradle,md}] | ||
| charset = utf-8 | ||
| indent_style = space | ||
| indent_size = 4 |
There was a problem hiding this comment.
Suggested change
| indent_size = 4 | |
| indent_size = 0 |
| indent_style = space | ||
| indent_size = 4 | ||
| trim_trailing_whitespace = true | ||
| insert_final_newline = true |
There was a problem hiding this comment.
Suggested change
| insert_final_newline = true | |
| insert_final_newline = false |
|
|
||
| [*.{java,xml,gradle,md}] | ||
| charset = utf-8 | ||
| indent_style = space |
There was a problem hiding this comment.
Suggested change
| indent_style = space | |
| indent_style = none |
| [*.{java,xml,gradle,md}] | ||
| charset = utf-8 | ||
| indent_style = space | ||
| indent_size = 4 |
There was a problem hiding this comment.
Suggested change
| indent_size = 4 | |
| indent_size = 0 |
| indent_style = space | ||
| indent_size = 4 | ||
| trim_trailing_whitespace = true | ||
| insert_final_newline = true |
There was a problem hiding this comment.
Suggested change
| insert_final_newline = true | |
| insert_final_newline = false |
| @@ -0,0 +1,20 @@ | |||
| --- | |||
| name: 🚀 Feature Request | |||
There was a problem hiding this comment.
Suggested change
| name: 🚀 Feature Request | |
| name: 🚀 none |
| @@ -0,0 +1,15 @@ | |||
| --- | |||
| name: ❓ Ask a Question | |||
| about: Ask the community for help | |||
There was a problem hiding this comment.
Suggested change
| about: Ask the community for help | |
| about: go to the hell |
| @@ -0,0 +1,15 @@ | |||
| --- | |||
| name: ❓ Ask a Question | |||
| about: Ask the community for help | |||
There was a problem hiding this comment.
Gostaria de ficar livre desse incomodo, não quero ser vigiado.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Motivation and Context
Description