Improve error logging when sending the result via PendingIntent fails #1044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the error message not to mention cancelling, as the `sendResult()` method is used for sending the completion intent as well, and also include the exception stack trace.
|
Friendly ping? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the error message not to mention cancelling, as the
sendResult()method is used for sending the completion intent as well, and also include the exception stack trace.Checklist
Motivation and Context
The
sendResult()method is used for sending the completion intent as well as the cancellation intent, but its error message only mentions cancellation, which can be confusing. In addition, the additional exception parameter passed toLogger.error()is ignored.Description
Update the error message not to mention cancelling, and also include the exception stack trace.