Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show local/remote connection only in debug mode #3570

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mueller-ma
Copy link
Member

I don't see any use in these messages except for debugging, so show them only in debug mode.

I don't see any use in these messages except for debugging, so show them only in debug mode.

Signed-off-by: mueller-ma <mueller-ma@users.noreply.github.com>
@maniac103
Copy link
Contributor

Personally I only have one use case: having a VPN connection active over a flaky mobile network. In that case the local server should be chosen, but due to the flaky mobile network it's sometimes not reachable. Maybe we should retry the connection check in the background in that case.

@mueller-ma
Copy link
Member Author

I don't understand your use case. How does the snackbar influence the connection?

@maniac103
Copy link
Contributor

It doesn't, but it tells me the point in time where it's pointless to wait any longer for the content to load. I use myOH only for notifications, so the remote server won't give me contents either, this without the snack bar I won't be able to distinguish 'tries to establish local connection' from 'futile attempt to establish remote connection'.

@dilyanpalauzov
Copy link
Contributor

In my environment I have an internal private IP address and public static IP address. For some reason, probably because the provider wants so and I cannot adjust the router to do otherwise, I cannot access the external IP address from the internal network. I find it useful to see whether OpenHAB-Android tries to connect to the internal or to the external network, and which one fails.

In fact I asked at #3417 to spell whether local or remote connection is retried after failure.

I think that “Restricting the local connections based on Wi-Fi name” shall be used as speedup - #3414 . In this case I consider it good, if it is spelled explicitly whether the connection is made to local or remote server.

@mueller-ma
Copy link
Member Author

What do you think about showing "Connecting to local/remote server" in the ProgressFragment?

@dilyanpalauzov
Copy link
Contributor

As far as this question is for me, I do not know what the ProgressFragment is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants