⬆️ videojs upgrade #2535
Draft
⬆️ videojs upgrade #2535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AntoLC
force-pushed
the
feature/anthony/videojs-upgrade
branch
5 times, most recently
from
50feaf9
to
5e41fbe
Compare
AntoLC
force-pushed
the
feature/anthony/videojs-upgrade
branch
3 times, most recently
from
17be18d
to
2c33cc9
Compare
A new version of video.js was available, we upgraded to it.
The official videojs-http-source-selector on npm is not compatible with video.js version 8, this forked version is compatible. We decided to use this version in waiting the official version to be compatible with video.js version 8.
We adapt the plugin downloadVideoPlugin to work with video.js version 8.
We adapt the plugin id3Plugin to work with video.js version 8.
We adapt the plugin p2pHlsPlugin to work with video.js version 8.
We adapt the plugin qualitySelectorPlugin to work with video.js version 8.
We adapt the plugin sharedMediaPlugin to work with video.js version 8.
We adapt the plugin transcriptPlugin to work with video.js version 8.
We adapt the plugin xapiPlugin to work with video.js version 8.
When we adapted the class in the plugin video.js, we use the keyword "declare", which is not interpreted by babel. We need to add a plugin to babel to interpret this keyword correctly.
lunika
force-pushed
the
feature/anthony/videojs-upgrade
branch
from
2c33cc9
to
0ac7324
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Upgrade video.js to version 8.
Proposal
Notes
The official
videojs-http-source-selectoris not compatible with the version 8, we found a fork of it thatis compatible: https://github.com/FreeTubeApp/videojs-http-source-selector.git