Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Grommet components reporting #2315

Open
wants to merge 11 commits into
base: master
Choose a base branch
from
Open

Conversation

AlfredPichard
Copy link
Contributor

@AlfredPichard AlfredPichard commented Jul 6, 2023

Purpose

This PR, not aimed to be merged, adds a new config file for react-scanner to report the grommet components in marsha frontend.
Ultimately, we would like to reduce the number of grommet components that we use in marsha. This first step gives us a state of the art of the current presence of it in our code.

Proposal

The goal is to keep track of the previous report files and use the config file regularly to visualize the progression of grommet removal.

Results

July 2023 :

  "Box": 560,
  "Text": 153,
  "Button": 90,
  "Heading": 47,
  "Paragraph": 42,
  "TextInput": 21,
  "Stack": 18,
  "FormField": 17,
  "Spinner": 17,
  "Tab": 15,
  "Select": 12,
  "Form": 10,
  "Grid": 10,
  "CheckBox": 9,
  "ThemeContext.Extend": 9,
  "Image": 8,
  "Alert": 7,
  "AddCircle": 6,
  "Grommet": 6,
  "Tabs": 6,
  "TextArea": 6,
  "Anchor": 5,
  "Layer": 5,
  "Clock": 3,
  "DropButton": 3,
  "FormView": 3,
  "Hide": 3,
  "Meter": 3,
  "Pagination": 3,
  "CardBody": 2,
  "Collapsible": 2,
  "Document": 2,
  "DocumentStore": 2,
  "Footer": 2,
  "FormClose": 2,
  "Schedule": 2,
  "StatusGoodSmall": 2,
  "CardFooter": 1,
  "CardHeader": 1,
  "CircleAlert": 1,
  "Clear": 1,
  "DateInput": 1,
  "DocumentText": 1,
  "Facebook": 1,
  "Filter": 1,
  "FormCheckmark": 1,
  "FormRefresh": 1,
  "FormSchedule": 1,
  "Github": 1,
  "InProgress": 1,
  "Linkedin": 1,
  "Mail": 1,
  "Menu": 1,
  "Nav": 1,
  "RadioButton": 1,
  "ResponsiveContext.Provider": 1,
  "Search": 1,
  "SettingsOption": 1,
  "StatusGood": 1,
  "TextWrap": 1,
  "Tip": 1,
  "Trash": 1,
  "Twitter": 1

@AlfredPichard AlfredPichard self-assigned this Jul 6, 2023
@AntoLC AntoLC self-assigned this Sep 26, 2023
@AntoLC AntoLC force-pushed the report/grommet_reporting branch 2 times, most recently from 3f1914c to 195ed6a Compare November 27, 2023 15:20
AlfredPichard and others added 11 commits December 5, 2023 17:54
add a new config file for react-scanner to report the grommet
components in marsha frontend.
Ultimately, we would like to reduce the number of grommet components
that we use in marsha. This first step gives us a state of the art of
the current presence of it in our code.
- Move config files to src/frontend
- Move report.json to src/frontend
- Add command grommet-scan to package.json
Report for 26/09/2023 about the grommet component left.
Report for 27/09/2023 about the grommet component left.
The scan was scanning grommet-icons as well, which is not needed
for the moment. This commit will allow us to scan only grommet
and not grommet-icons.
Report for 29/09/2023 about the grommet component left.
Report for 04/10/2023 about the grommet component left.
Report for 09/11/2023 about the grommet component left.
Report for 22/11/2023 about the grommet component left.
Report for 27/11/2023 about the grommet component left.
Report for 05/12/2023 about the grommet component left.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants