Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ofMesh - newfaces push_back to insert a list #7772

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

ofMesh - newfaces push_back to insert a list #7772

wants to merge 2 commits into from

Conversation

dimitre
Copy link
Member

@dimitre dimitre commented Nov 23, 2023

Splitting from more complex PR #7493

@dimitre dimitre marked this pull request as draft November 23, 2023 16:40
@ofTheo
Copy link
Member

ofTheo commented Nov 28, 2023

looks like issues with the changes - in the VS action:

  ofMesh.inl(2210,5): error C2398: Element '2': conversion from 'unsigned __int64' to '_Ty' requires a narrowing conversion 
  ofMesh.inl(2211,5): error C2398: Element '3': conversion from 'unsigned __int64' to '_Ty' requires a narrowing conversion 
  ofMesh.inl(2213,5): error C2398: Element '5': conversion from 'unsigned __int64' to '_Ty' requires a narrowing conversion 
  ofMesh.inl(2214,5): error C2398: Element '6': conversion from 'unsigned __int64' to '_Ty' requires a narrowing conversion 
  ofMesh.inl(2216,5): error C2398: Element '8': conversion from 'unsigned __int64' to '_Ty' requires a narrowing conversion 
  ofMesh.inl(2217,5): error C2398: Element '9': conversion from 'unsigned __int64' to '_Ty' requires a narrowing conversion 
  ofMesh.inl(2218,5): error C2398: Element '10': conversion from 'unsigned __int64' to '_Ty' requires a narrowing conversion 
  ofMesh.inl(2219,5): error C2398: Element '11': conversion from 'unsigned __int64' to '_Ty' requires a narrowing conversion 
  ofMesh.inl(2220,5): error C2398: Element '12': conversion from 'unsigned __int64' to '_Ty' requires a narrowing conversion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dimitre @ofTheo