Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Add new open food facts icon #4908

Merged
merged 4 commits into from Jan 25, 2023
Merged

style: Add new open food facts icon #4908

merged 4 commits into from Jan 25, 2023

Conversation

dmdbilal
Copy link
Contributor

Description

Changed the old open food facts icon with the new icon.

Related issues

Linked issue #4848

Screenshots

Before After

@dmdbilal dmdbilal requested a review from a team as a code owner January 23, 2023 07:21
@dmdbilal dmdbilal changed the title Add new open food facts icon style: Add new open food facts icon Jan 23, 2023
@VaiTon
Copy link
Member

VaiTon commented Jan 23, 2023

Hey @dmdbilal! I saw you changed the icon in the main directory. This way it is applied to every flavor. It should be changed in the off/res folder instead.

@sonarcloud
Copy link

sonarcloud bot commented Jan 23, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@VaiTon VaiTon merged commit 3781343 into openfoodfacts:develop Jan 25, 2023
@VaiTon
Copy link
Member

VaiTon commented Jan 25, 2023

Thank you @dmdbilal !

VaiTon pushed a commit that referenced this pull request Feb 1, 2023
…con (#4910)

####  Description
<!--Give a small description related to the changes you have made.-->
Added new open pet food facts, open beauty facts, open product icon.

#### Related issues
<!--
- Add the issue number here.
- If you haven't solved the issue completely use "Linked issue
#{issue_number}.
- If you have solved the issue completely use "Fixes #{issue_number},
example: "Fixes #123, #345".
-->
Linked Issue #4848 

#### Related PRs
<!-- Link to all the related PRs openfoodfacts-androidapp,
openfoodfacts-server, openfoodfacts-ios, etc. -->
#4908
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants