Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: [Rebase of initial PR] Allow the users to get Nutri-Score, NOVA and Eco-Score even if they don't have any Network #3288

Open
wants to merge 15 commits into
base: develop
Choose a base branch
from
Open

feat: [Rebase of initial PR] Allow the users to get Nutri-Score, NOVA and Eco-Score even if they don't have any Network #3288

wants to merge 15 commits into from

Conversation

teolemon
Copy link
Member

@teolemon teolemon commented Jun 21, 2020 •
edited

Description

A prompt to download the CSV file at the start and saving it in batches of 15k products to the local database, in order to allow offline scanning.
https://world.openfoodfacts.org/data/offline/en.openfoodfacts.org.products.small.csv.zip

Related issues and discussion

Future

  • Implement offline scanning based on the locally stored data
  • Try fetching the data online in parallel and refresh the view if necessary
  • Align the data download UX with what has been done in iOS
  • I would probably create a real activity showing progress report rather than a menu item that you have to click twice and that doesn't change to indicate progress
  • ability to delete the offline db and re-download it (or even a scheduled task every month)
  • have a small version (the current one) and full versions (without images) for a whole country
  • Add a first time use info in home like on iOS

Part of

Screenshots

image

image

image

prashantkh19 and others added 15 commits February 26, 2019 02:55
@prashantkh19
Fixes Issue #2069: downloaded offline_product_data zip file and store…
67377bf 
…d in the database.
@prashantkh19
Fixes Issue #2069: optimized scanning and saving to database operations.
c7a0e32
@prashantkh19
Added Nav Menu option for downloading and saving offline zip and made…
b67df18 
… two independent intent service for downloading and saving.
@prashantkh19
Added a separate menu for offline Products.
0e8cf7c
@prashantkh19
added resource file
c97e25f
@prashantkh19
changed url and filename into non-translatable string resource
e915e77
@prashantkh19
Summary:
6918c8a 
1.Merged the download and extract process into one.
2. Merged offline product edit and product download fragment
@teolemon
Merge branch 'master' into 2069
ccb3170
@teolemon
Merge branch 'master' into 2069
05bbced
@teolemon
Merge branch 'master' into 2069
c2d548a
@teolemon
Merge branch 'master' into 2069
b4e159c
@teolemon
Merge branch 'master' into 2069
ed67d98
@teolemon
Merge branch 'master' into 2069
0db3795
@teolemon
Merge branch 'master' into 2069
a078142
@teolemon
Merge branch 'master' into pr/2102
b750223
@teolemon teolemon requested a review from VaiTon June 21, 2020 10:07
@sonarcloud
Copy link

sonarcloud bot commented Jun 21, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@teolemon teolemon added the offline Offline mode label Jun 21, 2020
@teolemon
Copy link
Member Author

@elouataoui @prashantkh19 FYI, I moved the PR

@teolemon teolemon added the P1 label Jun 21, 2020
@VaiTon
Copy link
Member

VaiTon commented Jun 21, 2020

@teolemon I would like to discuss on slack before I start working on this one.

@teolemon teolemon changed the base branch from master to develop July 22, 2020 15:41
@teolemon teolemon linked an issue Sep 4, 2020 that may be closed by this pull request
Store the whole database (or a subset) locally #30
Closed
@teolemon teolemon changed the title Offline mode rebased [Rebase of initial PR] Allow the user to get Nutri-Score, NOVA and Eco-Score even if they don't have any Network Aug 31, 2021
@teolemon teolemon changed the title [Rebase of initial PR] Allow the user to get Nutri-Score, NOVA and Eco-Score even if they don't have any Network [Rebase of initial PR] Allow the users to get Nutri-Score, NOVA and Eco-Score even if they don't have any Network Aug 31, 2021
@teolemon teolemon mentioned this pull request Aug 31, 2021
Open
9 tasks
@teolemon teolemon changed the title [Rebase of initial PR] Allow the users to get Nutri-Score, NOVA and Eco-Score even if they don't have any Network feat: [Rebase of initial PR] Allow the users to get Nutri-Score, NOVA and Eco-Score even if they don't have any Network Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VaiTon VaiTon Awaiting requested review from VaiTon

@philippeauriach philippeauriach Awaiting requested review from philippeauriach

Assignees
No one assigned
Labels
help wanted merge conflicts offline Offline mode P1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Up for Adoption] Allow to scan barcodes offline Store the whole database (or a subset) locally
3 participants
@teolemon @VaiTon @prashantkh19