chore: update go-grpc-prometheus middleware to use fork with grpc_code
#895
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Switches from the now deprecated
github.com/grpc-ecosystem/go-grpc-prometheus
package to a forked versiongithub.com/jon-whit/go-grpc-prometheus
. The fork includes changes that add thegrpc_code
label to thegrpc_server_handling_seconds
histogram.The newer upstream project
github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus
also does not yet have thegrpc_code
included in thegrpc_server_handling_seconds
histogram. There doesn't seem to be consensus on if that label should be added, but since we need it to define sensible SLOs, we forked and added it.Here's a screenshot of these changes in action:
References
Related issues:
grpc-ecosystem/go-grpc-middleware#606
grpc-ecosystem/go-grpc-prometheus#75
Review Checklist
main