Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update go-grpc-prometheus middleware to use fork with grpc_code #895

Merged
merged 1 commit into from
Jul 28, 2023

Conversation

jon-whit
Copy link
Member

@jon-whit jon-whit commented Jul 28, 2023

Description

Switches from the now deprecated github.com/grpc-ecosystem/go-grpc-prometheus package to a forked version github.com/jon-whit/go-grpc-prometheus. The fork includes changes that add the grpc_code label to the grpc_server_handling_seconds histogram.

The newer upstream project github.com/grpc-ecosystem/go-grpc-middleware/providers/prometheus also does not yet have the grpc_code included in the grpc_server_handling_seconds histogram. There doesn't seem to be consensus on if that label should be added, but since we need it to define sensible SLOs, we forked and added it.

Here's a screenshot of these changes in action:
Screen Shot 2023-07-28 at 2 51 01 PM

References

Related issues:
grpc-ecosystem/go-grpc-middleware#606
grpc-ecosystem/go-grpc-prometheus#75

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@jon-whit jon-whit requested a review from a team as a code owner July 28, 2023 20:50
@codecov
Copy link

codecov bot commented Jul 28, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.10% ⚠️

Comparison is base (6efcac9) 82.20% compared to head (609f447) 82.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #895      +/-   ##
==========================================
- Coverage   82.20%   82.09%   -0.10%     
==========================================
  Files          64       64              
  Lines        7666     7666              
==========================================
- Hits         6301     6293       -8     
- Misses       1065     1070       +5     
- Partials      300      303       +3     
Files Changed Coverage Δ
cmd/run/run.go 72.04% <ø> (+0.33%) ⬆️

... and 4 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jon-whit jon-whit merged commit 4856180 into main Jul 28, 2023
11 checks passed
@jon-whit jon-whit deleted the update-prometheus-middleware-with-fork branch July 28, 2023 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants