Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding python3-fastapi templates #287

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

JustinGuese
Copy link

Adding python3-fastapi and python3-fastapi-debian to the templates

Description

It would be awesome to have the fastapi templates in the main repo. I used https://github.com/loudsquelch/openfaas-python3-fastapi-template for my additions and created an alpine and debian version similar to the python3 ones you are providing.

Motivation and Context

The default python3 module is okayish, but with fastapi we can have the advantages of that library in openfaas. I have specified workers 1 to leave the scaling up to openfaas. The /doc route should be exposed as usual and all in all it should provide a better way of integrating APIs with OpenFAAS.

Which issue(s) this PR fixes

How Has This Been Tested?

I deployed both functions to my local OpenFAAS setup and ran the ./verify.sh script

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Version change (see: Impact to existing users)

Impact to existing users

Two new templates are added that do not change the existing python3 and python3-debian templates

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@derek
Copy link

derek bot commented Mar 11, 2022

Thank you for your contribution. unfortunately, one or more of your commits are missing the required "Signed-off-by:" statement. Signing off is part of the Developer Certificate of Origin (DCO) which is used by this project.

Read the DCO and project contributing guide carefully, and amend your commits using the git CLI. Note that this does not require any cryptography, keys or special steps to be taken.

💡 Shall we fix this?

This will only take a few moments.

First, clone your fork and checkout this branch using the git CLI.

Next, set up your real name and email address:

git config --global user.name "Your Full Name"
git config --global user.email "you@domain.com"

Finally, run one of these commands to add the "Signed-off-by" line to your commits.

If you only have one commit so far then run: git commit --amend --signoff and then git push --force.
If you have multiple commits, watch this video.

Check that the message has been added properly by running "git log".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant