Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

serial: Fix empty package and use shared lib instead of static lib. #809

Closed
wants to merge 3 commits into from

Conversation

magicwenli
Copy link
Contributor

The older recipe of serial built a static lib libserial.a.

Which was contained in FILES_${PN}-dev and FILES_${PN} is empty.

This will make bitbake unhapply and raise Nothing provides serial needed by other-recipe problem.

To fix it we need add CMake set_target_properties function.

see also:

  1. https://docs.yoctoproject.org/pipermail/yocto/2015-January/022921.html
  2. https://stackoverflow.com/questions/59091938/yocto-oe-recipe-with-cmake-install-a-shared-library-so

Copy link
Contributor

@kraj kraj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you submit this patch upstream ? and also set Upstream-Status in the patch accordingly.

@magicwenli
Copy link
Contributor Author

@kraj Thanks for your reminder. I have appended Upstream-Status label.

I noticed that the maintainer of the serial project has not had any activity in the past 10 months. Maybe in this case we can merge it directly into meta-oe.

@kraj
Copy link
Contributor

kraj commented Apr 15, 2024

@magicwenli
Copy link
Contributor Author

https://errors.yoctoproject.org/Errors/Details/763022/

Sorry. I have not test ptest feature on my project.

Can you give me some hint for fix unimplemented-ptest Error?

I noticed that we have CATKIN_ENABLE_TESTING macro to enable test binary building. But I don't know how to make them integrating with ptest.

https://github.com/wjwwood/serial/blob/main/tests/CMakeLists.txt

@kraj
Copy link
Contributor

kraj commented Apr 30, 2024

https://errors.yoctoproject.org/Errors/Details/763022/

Sorry. I have not test ptest feature on my project.

Can you give me some hint for fix unimplemented-ptest Error?

I noticed that we have CATKIN_ENABLE_TESTING macro to enable test binary building. But I don't know how to make them integrating with ptest.

https://github.com/wjwwood/serial/blob/main/tests/CMakeLists.txt

Enable ptest via adding it to local.conf

DISTRO_FEATURES:append = " ptest"

then try building it again.

@kraj
Copy link
Contributor

kraj commented May 4, 2024

fixed with 224eb26

@kraj kraj closed this May 4, 2024
@magicwenli
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants