This repository has been archived by the owner on May 6, 2024. It is now read-only.
chore: learner feedback collection from the mobile app #1819
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shafqat-muneer
suggested changes
Feb 15, 2024
Source/OEXAnalytics+Swift.swift
Outdated
| @@ -103,6 +103,7 @@ public enum AnalyticsDisplayName : String { | |||
| case PrivacyPolicyClicked = "Privacy Policy Clicked" | |||
| case CookiePolicyClicked = "Cookie Policy Clicked" | |||
| case DataSellConsentClicked = "Do Not Sell Data Clicked" | |||
| case SubmitFeedbackCLicked = "Submit feedback clicked" | |||
There was a problem hiding this comment.
Typo: SubmitFeedbackCLicked to SubmitFeedbackClicked
Source/OEXAnalytics+Swift.swift
Outdated
| @@ -194,6 +195,7 @@ public enum AnalyticsEventName: String { | |||
| case PrivacyPolicyClicked = "edx.bi.app.profile.privacy_policy.clicked" | |||
| case CookiePolicyClicked = "edx.bi.app.profile.cookie_policy.clicked" | |||
| case DataSellConsentClicked = "edx.bi.app.profile.do_not_sell_data.clicked" | |||
| case SubmitFeedbackCLicked = "edx.bi.app.profile.submit_feedback.clicked" | |||
There was a problem hiding this comment.
Typo: SubmitFeedbackCLicked to SubmitFeedbackClicked
saeedbashir
added a commit
that referenced
this pull request
Feb 15, 2024
This reverts commit 5b53fca.
saeedbashir
added a commit
that referenced
this pull request
Feb 15, 2024
saeedbashir
added a commit
that referenced
this pull request
Feb 15, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
LEARNER-9833