Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

Docs: Broken link #1816

Closed

Conversation

CodeWithEmad
Copy link

This will fix one broken link and remove another link that doesn't exist anymore in README.md.

@openedx-webhooks openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Dec 9, 2023
@openedx-webhooks
Copy link

Thanks for the pull request, @CodeWithEmad! Please note that it may take us up to several weeks or months to complete a review and merge your PR.

Feel free to add as much of the following information to the ticket as you can:

  • supporting documentation
  • Open edX discussion forum threads
  • timeline information ("this must be merged by XX date", and why that is)
  • partner information ("this is a course on edx.org")
  • any other information that can help Product understand the context for the PR

All technical communication about the code itself will be done via the GitHub pull request interface. As a reminder, our process documentation is here.

Please let us know once your PR is ready for our review and all tests are green.

@mphilbrick211 mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Dec 11, 2023
@e0d
Copy link
Contributor

e0d commented Dec 14, 2023

I've run the tests and added @CodeWithEmad to the triage team so tests will run automatically in the future.

@e0d
Copy link
Contributor

e0d commented Dec 14, 2023

@CodeWithEmad looks like there are some test failures, can you have a look?

@e0d e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Dec 14, 2023
@CodeWithEmad
Copy link
Author

Updating the README broke the tests due to snapshot issues. Not my strong suit (and probably needs macOS) but wanted to help. Can close if no one has time to fix.

@mphilbrick211
Copy link

Hi @CodeWithEmad! Just checking in to see if you plan to pursue this pull request?

@CodeWithEmad
Copy link
Author

Can't take it any further than this. I'll close it.
@mphilbrick211

@openedx-webhooks
Copy link

@CodeWithEmad Even though your pull request wasn’t merged, please take a moment to answer a two question survey so we can improve your experience in the future.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
open-source-contribution PR author is not from Axim or 2U
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants