Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

fix: Configuration Updates To Setup Fresh Codebase #1815

Merged
merged 1 commit into from Dec 7, 2023

Conversation

shafqat-muneer
Copy link
Contributor

@shafqat-muneer shafqat-muneer commented Dec 6, 2023

LEARNER-9733

Description

During the initial setup of the new repository, I encountered Errors and Warnings after executing the pod install command. However, after implementing these adjustments, the repository is now free of errors and warnings. Consequently, new users can effortlessly clone the repository and install the necessary pods.

Previous error encountered:

[!] The following Swift pods cannot yet be integrated as static libraries:

The Swift pod `FirebaseRemoteConfig` depends upon `FirebaseABTesting` and `FirebaseInstallations`, which do not define modules. To opt into those targets generating module maps (which is necessary to import them from Swift when building as static libraries), you may set `use_modular_headers!` globally in your Podfile, or specify `:modular_headers => true` for particular dependencies.

Previous warnings encountered:

[!] The `edX [Debug]` target overrides the `FRAMEWORK_SEARCH_PATHS` build setting defined in `Pods/Target Support Files/Pods-edX/Pods-edX.debug.xcconfig'. This can lead to problems with the CocoaPods installation
    - Use the `$(inherited)` flag, or
    - Remove the build settings from the target.

[!] The `edX [Release]` target overrides the `FRAMEWORK_SEARCH_PATHS` build setting defined in `Pods/Target Support Files/Pods-edX/Pods-edX.release.xcconfig'. This can lead to problems with the CocoaPods installation
    - Use the `$(inherited)` flag, or
    - Remove the build settings from the target.

[!] The `edX [Profile]` target overrides the `FRAMEWORK_SEARCH_PATHS` build setting defined in `Pods/Target Support Files/Pods-edX/Pods-edX.profile.xcconfig'. This can lead to problems with the CocoaPods installation
    - Use the `$(inherited)` flag, or
    - Remove the build settings from the target.

How to test this PR

To validate this pull request, it is necessary to clone the new repository and execute the pod install command, ensuring the absence of any errors or warnings.

Copy link
Contributor

@saeedbashir saeedbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As now the use_modular_headers is being used as file level, could you please remove
:modular_headers => true used for individual pods. Please do the same for edXTests target.

@shafqat-muneer
Copy link
Contributor Author

@saeedbashir Done with suggested changes.

Podfile Outdated
@@ -1,4 +1,6 @@
# Uncomment this line to define a global platform for your project
use_modular_headers!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess you need to change the use_modular_headers position or delete the comment.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done by changing the position.

Copy link
Contributor

@saeedbashir saeedbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@shafqat-muneer shafqat-muneer merged commit a2a6127 into master Dec 7, 2023
2 of 6 checks passed
@shafqat-muneer shafqat-muneer deleted the Shafqat/Configuration branch December 7, 2023 08:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants