Skip to content
This repository has been archived by the owner on May 6, 2024. It is now read-only.

chore: add collapsible section headers #1726

Merged
merged 21 commits into from Mar 14, 2023
Merged

chore: add collapsible section headers #1726

merged 21 commits into from Mar 14, 2023

Conversation

mumer92
Copy link
Contributor

@mumer92 mumer92 commented Feb 14, 2023

Description

LEARNER-8927

This PR adds collapsible section headers to course outline

Source/CourseOutlineHeaderCell.swift Outdated Show resolved Hide resolved
Source/CourseOutlineHeaderCell.swift Outdated Show resolved Hide resolved
Source/CourseOutlineHeaderCell.swift Outdated Show resolved Hide resolved
Source/CourseOutlineHeaderCell.swift Outdated Show resolved Hide resolved
Source/CourseOutlineHeaderCell.swift Outdated Show resolved Hide resolved
Source/CourseOutlineItemView.swift Outdated Show resolved Hide resolved
Source/CourseOutlineTableSource.swift Outdated Show resolved Hide resolved
Copy link
Contributor

@saeedbashir saeedbashir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@mumer92 mumer92 force-pushed the umer/LEARNER-8927 branch 3 times, most recently from 2ad53b0 to ac92036 Compare March 13, 2023 11:52
@mumer92 mumer92 merged commit 5a1c318 into app_nav Mar 14, 2023
@mumer92 mumer92 deleted the umer/LEARNER-8927 branch March 14, 2023 13:17
@mumer92 mumer92 restored the umer/LEARNER-8927 branch March 16, 2023 06:23
@mumer92 mumer92 deleted the umer/LEARNER-8927 branch March 16, 2023 06:27
saeedbashir pushed a commit that referenced this pull request Sep 19, 2023
*chore: revert app nav changes (#1685)

* chore: add indicator on tab bar (#1687)

* chore: update learn tab icon (#1698)

* chore: add empty state to my courses (#1697)

* chore: add dashboard header view (#1705)

* chore: Course Dashboard Error Screen for Non-Upgradable Courses (#1708)

* chore: course tab bar flow changes in course dashboard (#1707)

* chore: add error view on enrolled courses screen (#1718)

* chore: course dashboard error screen for no access but upgradable courses (#1716)

* chore: scrolling behaviour on course dashboard header (#1723)

* feat: add new error screen for outdated version (#1725)

* feat: certificate banner stylistic changes on new course dashboard (#1727)

* chore: add scrolling behaviour to redesigned Learn tab (#1729)

* chore: add collapsible section headers (#1726)

* chore: resume course button implementation for new design #1737 (#1738)

* chore: fix deeplinks with new dashboard (#1742)

* fix: fix broken tests

* chore: discussions deep link and push notifications support for new course dashboard (#1752)

* chore: update status bar color to match course dashboard header color (#1754)

* feat: show shift dates banner on new course dashboard (#1753)

* feat: show shift dates banner on new course dashboard
* refactor: improve value prop logic in case of embedded value prop on course dashboard
fix: fix fetching of course price

* fix: fix course share button on iPad (#1757)

* fix: fix blank screen on fresh enrollment with app nav work (#1759)

* fix: view showing behind collapsible headers (#1758)

* chore: unit and component navigation (#1748)

* chore: handle user interaction when user swipes quickly in page view controller (#1766)

* chore: incorporate changes of course price and currency code for execute api in app_nav (#1768)

* refactor: celebratory modal layout improvements (#1767)

* chore: handle landscape for new dashboard and component navigation (#1769)

* chore: address app nav feedback (#1772)

* chore: fix title label constraint (#1775)

* fix:  revert of fix title label constraint (#1775)" (#1778)

* fix: fix unable to dismiss an error message from course list screen (#1777)

* fix: fix for subsection unwanted collapse (#1776)

* fix: fix crash on new enrollment on course dashboard (#1781)

* chore: expand next section after a section is marked as completed (#1782)

* chore: update the edit screen title to Personal information (#1785)

* chore: update shift dates banner on component screen (#1786)

* chore: improve scrolling experience on discover title bar (#1788)

* chore: handle header view in video block (#1798)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants