fix: Layout discrepancy on landscape mode (#1735)

openedx-unsupported · Mar 14, 2023 · 45725f8 · 45725f8
1 parent bf1c52d
commit 45725f8
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 10 deletions.
diff --git a/Source/CourseUnknownBlockViewController.swift b/Source/CourseUnknownBlockViewController.swift
@@ -163,10 +163,10 @@ class CourseUnknownBlockViewController: UIViewController, CourseBlockViewControl
         view.backgroundColor = OEXStyles.shared().neutralWhiteT()
 
         valuePropView.snp.makeConstraints { make in
-            make.top.equalTo(view).offset(StandardVerticalMargin * 2)
-            make.leading.equalTo(view)
-            make.trailing.equalTo(view)
-            make.bottom.equalTo(view)
+            make.top.equalTo(safeTop).offset(StandardVerticalMargin * 2)
+            make.leading.equalTo(safeLeading)
+            make.trailing.equalTo(safeTrailing)
+            make.bottom.equalTo(safeBottom)
         }
     }
 

diff --git a/Source/DiscoveryWebViewHelper.swift b/Source/DiscoveryWebViewHelper.swift
@@ -57,10 +57,7 @@ class DiscoveryWebViewHelper: NSObject {
         guard let container = delegate?.webViewContainingController() else { return }
         container.view.addSubview(contentView)
         contentView.snp.makeConstraints { make in
-            make.top.equalTo(0)
-            make.trailing.equalTo(container.view)
-            make.leading.equalTo(container.view)
-            make.bottom.equalTo(container.view)
+            make.edges.equalTo(container.safeEdges)
         }
         loadController.setupInController(controller: container, contentView: contentView)
         refreshController.setupInScrollView(scrollView: webView.scrollView)

diff --git a/Source/HTMLBlockViewController.swift b/Source/HTMLBlockViewController.swift
@@ -101,8 +101,8 @@ class HTMLBlockViewController: UIViewController, CourseBlockViewController, Prel
             }
 
             openInBrowserView.snp.remakeConstraints { make in
-                make.leading.equalTo(view)
-                make.trailing.equalTo(view)
+                make.leading.equalTo(safeLeading)
+                make.trailing.equalTo(safeTrailing)
                 make.top.equalTo(webController.view.snp.bottom)
                 make.height.equalTo(55)
                 make.bottom.equalTo(safeBottom)