Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: mod path of image pull secret #505

Merged
merged 1 commit into from
Jun 4, 2024
Merged

chore: mod path of image pull secret #505

merged 1 commit into from
Jun 4, 2024

Conversation

chriswldenyer
Copy link
Contributor

Move the image pull secret to be under image, not base.

Description

Move the image pull secret to be under image, not base.
This is the more logical location.

Motivation and Context

Regression

No

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added unit tests to cover my changes.

tiagolobocastro
tiagolobocastro approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@tiagolobocastro tiagolobocastro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please run helm upgrade manually (previous install with secrets enabled) to ensure it's working

chart/templates/_helpers.tpl Outdated Show resolved Hide resolved
dsharma-dc
dsharma-dc reviewed May 16, 2024
View reviewed changes
chart/values.yaml Outdated Show resolved Hide resolved
tiagolobocastro
tiagolobocastro reviewed May 17, 2024
View reviewed changes
chart/values.yaml Outdated Show resolved Hide resolved
@chriswldenyer
Copy link
Contributor Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request May 20, 2024
Try #505:
48928b5
@bors-openebs-mayastor
Copy link
Contributor

try

Build succeeded:

tiagolobocastro
tiagolobocastro approved these changes May 20, 2024
View reviewed changes
chart/values.yaml Outdated Show resolved Hide resolved
@chriswldenyer chriswldenyer force-pushed the secrets-location branch 2 times, most recently from 858fc85 to cebfddf Compare May 22, 2024 08:01
@chriswldenyer
Copy link
Contributor Author

bors try

bors-openebs-mayastor bot pushed a commit that referenced this pull request May 22, 2024
Try #505:
c0061fd
@bors-openebs-mayastor
Copy link
Contributor

try

Build succeeded:

niladrih
niladrih approved these changes May 28, 2024
View reviewed changes
Copy link
Member

@niladrih niladrih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Configuration lives through helm upgrade, no upgrade changes required.

@chriswldenyer chriswldenyer force-pushed the secrets-location branch 3 times, most recently from 12ecb02 to 48680f6 Compare May 29, 2024 07:25
@chriswldenyer
Copy link
Contributor Author

Re-requested reviews because of a change in the logic of the pull-secrets helper function.

@chriswldenyer
chore: mod path of image pull secret and use array
184448c 
Signed-off-by: chriswldenyer <christopher.denyer@mayadata.io>
@chriswldenyer
Copy link
Contributor Author

One further change - use default secret name of "login" if the legacy method is used to enable the secret and the name is not specified.

niladrih
niladrih reviewed Jun 3, 2024
View reviewed changes
Copy link
Member

@niladrih niladrih left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment.

chart/templates/_helpers.tpl Show resolved Hide resolved
@chriswldenyer
Copy link
Contributor Author

bors merge

@bors-openebs-mayastor
Copy link
Contributor

Build succeeded:

@bors-openebs-mayastor bors-openebs-mayastor bot merged commit ff5911e into develop Jun 4, 2024
5 checks passed
@bors-openebs-mayastor bors-openebs-mayastor bot deleted the secrets-location branch June 4, 2024 08:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tiagolobocastro tiagolobocastro tiagolobocastro approved these changes

@Abhinandan-Purkait Abhinandan-Purkait Abhinandan-Purkait approved these changes

@niladrih niladrih niladrih approved these changes

@dsharma-dc dsharma-dc Awaiting requested review from dsharma-dc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
5 participants
@chriswldenyer @tiagolobocastro @Abhinandan-Purkait @niladrih @dsharma-dc