Allow expansion of volumes with snapshots, or restored volumes #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsharma-dc
changed the title
dsharma-dc
requested review from
tiagolobocastro,
Abhinandan-Purkait and
niladrih
dsharma-dc
force-pushed
the
snap_resize_tests
branch
from
0220e89
to
e0176f5
Compare
tiagolobocastro
approved these changes
May 21, 2024
…tored volumes Till now we had a limitation that IO used to fail on an expanded volume if it had a snapshot before expansion. The issue is fixed in data-plane and hence this limitation is now being removed. Signed-off-by: Diwakar Sharma <diwakar.sharma@datacore.com>
Signed-off-by: Diwakar Sharma <diwakar.sharma@datacore.com>
dsharma-dc
force-pushed
the
snap_resize_tests
branch
from
e0176f5
to
67813b2
Compare
|
bors merge |
|
🕐 Waiting for PR status (GitHub check) to be set, probably by CI. Bors will automatically try to run when all required PR statuses are set. |
|
You forgot to change the PR title as well |
dsharma-dc
changed the title
Done now (y). Had changed commit title though. |
|
Build succeeded: |
|
You had to cancel bors... got merged with wrong title... |
Ah, bummer. Not a big deal I guess? the PR title just gets embedded in the description of merge commit. And it's not wrong per se, just needed rewording. |
|
Yeah no biggie |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.