Add pool spread topology key feature #756
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sinhaashish <ashi.sinha.87@gmail.com>
Signed-off-by: sinhaashish <ashi.sinha.87@gmail.com>
Signed-off-by: sinhaashish <ashi.sinha.87@gmail.com>
sinhaashish
requested review from
tiagolobocastro,
Abhinandan-Purkait and
dsharma-dc
| @@ -191,13 +191,6 @@ impl ResourceResize for OperationGuardArc<VolumeSpec> { | |||
| let spec = self.as_ref().clone(); | |||
| let state = registry.volume_state(&request.uuid).await?; | |||
|
|
|||
| // Pre-check - Don't allow resize if the volume has snapshots. | |||
There was a problem hiding this comment.
Why did you remove the snapshot check?
Comment on lines
+1013
to
+1014
| let is_spread_label_same = match &context.volume.as_ref().topology { | ||
| None => false, |
There was a problem hiding this comment.
Suggested change
| let is_spread_label_same = match &context.volume.as_ref().topology { | |
| None => false, | |
| let Some(topology) = context.volume.topology.as_ref() else { | |
| return Ok(false); | |
| }; |
Comment on lines
+1016
to
+1017
| match &topology.pool { | ||
| None => false, |
There was a problem hiding this comment.
again let Some else to reduce nesting..
| .specs() | ||
| .pool(&replica_candidate.pool_id)? | ||
| .labels | ||
| .unwrap_or_default(); |
There was a problem hiding this comment.
Can we not pass this information through the candidates type?
There was a problem hiding this comment.
Need to update the top of the file to include spread?
|
@sinhaashish What's the reason this PR is open? Is the change redundant or subsumed in any other merged PRs ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PoolSpreadTopologyKey: "performance" - is a exclusion
1: "performance: Gold"
2: "performance: Silver"
3: "performance: Emerald"