Major update V3 #181
Open
Major update V3 #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated steady state solver - Updated euler explicit solver - Nearest neighbor interpolation introduced to wind series interpolation. This avoids awkward values of wind directions. Both solvers eliminate the iteration of the linear system of equations. Performance of these solvers looks very good so far. No compatibility with spatially varying wind fields yet. Solvers only work when winds are located in 1 quadrant.
Sweeping method 2 has been introduced to facilitate spatially varying wind field. The solver seems not mass-conserving yet.
Duran grainspeed improved, such that us and un are 0 when ustar < uth
Fixed usage of threshold mask. 2D mask can be given as input and will be used to mask uth for each fraction over a loop
The addition of a vegetation-growth mask allows to disable vegetation growth at certain parts of the domain (for instance where vegetation species are non-burial resistant)
1. Included grain speed us & un from both upwind and current cell 2. Grain speeds determined at cell edge instead of center (now fluxes for mass conservation (and asymmetry))
When calling 'duran_full' under the grainspeed parameter, now the grainspeed equation (eq 1.61 in thesis Duran) is completely solved. This results in better outcomes for steep slopes. Implications for earlier simulations, e.g. barchans, parabolics is expected to be limited, but for more natural situations (mainly blowouts) this has a large (positive) impact on the outcomes.
solver could be optimized for speed boundary conditions are still under development.
Most functionalities are operational but some work remains on the boundaries.
sweep3 is the new solver code. This is tested for continuity on all quadrants. Sweep tests folder is added. This folder is to be deleted later.
- make facility for using supply file - nearest interpolation of wind input - sweep stopping criteria 1e-10 instead of 0
Vegetation.py updated, but not a definite version. Processes are missing and implementation is lacking. Waiting for a better description, before a clean and "final" implementation
Allow messy input files
niketagrawal
requested changes
Mar 14, 2024
| @@ -100,8 +100,8 @@ class TestAeoLiSRunner: | |||
|
|
|||
| def test_parse_callback_from_module(self): | |||
| """Test if the callback function can be loaded from a file""" | |||
| runner = AeoLiSRunner("aeolis/tests/aeolis.txt") | |||
| callback = runner.parse_callback("aeolis/tests/callback_example.py:mock_callback") | |||
| runner = AeoLiSRunner("aeolis.txt") | |||
There was a problem hiding this comment.
This path to aeolis.txt file is incorrect. It is causing the callback test to fail.
The correct path is "aeolis/tests/aeolis.txt"
| runner = AeoLiSRunner("aeolis/tests/aeolis.txt") | ||
| callback = runner.parse_callback("aeolis/tests/callback_example.py:mock_callback") | ||
| runner = AeoLiSRunner("aeolis.txt") | ||
| callback = runner.parse_callback("callback_example.py:mock_callback") |
There was a problem hiding this comment.
This path to the callback function is incorrect. It is causing the callback test to fail.
The correct path is "aeolis/tests/callback_example.py:mock_callback"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solver, vegetation, Landforms