Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and improve fe-ionic (master) #782

Merged
merged 1 commit into from Apr 27, 2022
Merged

Update and improve fe-ionic (master) #782

merged 1 commit into from Apr 27, 2022

Conversation

cschweikert
Copy link
Member

The following things in the current fe-ionic quickstarter have been updated, added or improved:

  • ionic: 6.13.1 -> 6.19.0
  • align code with fe-angular quickstarter including changes within fe-angular
  • removal of certain workarounds needed by current version
  • bring documentation up-to-speed

Fixes #780

Tasks:

  • Updated documentation in docs/modules/... directory
  • Ran tests in <quickstarter>/testdata directory

Please note

  1. Ionic replaced TSLint with ESLint.
  2. The unit testing capabilities are currently broken (see for exmple Quickstarter tests: Verifying Jenkins run attachments fails ods-core#1124 and Provisioning of projects doesn't setup Jenkins with Aqua credentials  ods-core#1125). I filled the gaps as good as I could with manual tests.
  3. There will be a follow-up PR for the 4.x branch.

@cschweikert cschweikert self-assigned this Apr 4, 2022
@cschweikert cschweikert changed the title Update and improve fe-ionic Update and improve fe-ionic (master) Apr 7, 2022
@cschweikert cschweikert merged commit 104d48c into master Apr 27, 2022
@cschweikert cschweikert deleted the update-fe-ionic branch April 28, 2022 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update and renew fe-ionic
2 participants