Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch fe-angular, fe-ionic and be-typescript-express to Node.js 16 builder agent (master) #775

Merged
merged 1 commit into from Apr 7, 2022
Merged

Switch fe-angular, fe-ionic and be-typescript-express to Node.js 16 builder agent (master) #775

merged 1 commit into from Apr 7, 2022

Conversation

cschweikert
Copy link
Member

Move quickstarters fe-angular, fe-ionic and be-typescript-express forward to use the new Node.js 16 builder agent for provisioning and building.

Fixes #763

Tasks:

  • Updated documentation in docs/modules/... directory
  • Ran tests in <quickstarter>/testdata directory

Please note

  1. The unit testing capabilities are currently broken (see for exmple Quickstarter tests: Verifying Jenkins run attachments fails ods-core#1124 and Provisioning of projects doesn't setup Jenkins with Aqua credentials  ods-core#1125). I filled the gaps as good as I could with manual tests.
  2. For also moving e2e-cypress to Node.js 16 there is Update and renew e2e-cypress #770
  3. There will be a follow-up PR for the 4.x branch.

@cschweikert cschweikert self-assigned this Apr 1, 2022
@cschweikert cschweikert changed the title Switch fe-angular, fe-ionic and be-typescript-express to Node.js 16 builder agent Switch fe-angular, fe-ionic and be-typescript-express to Node.js 16 builder agent (master) Apr 1, 2022
gerardcl
gerardcl previously approved these changes Apr 6, 2022
View reviewed changes
Copy link
Member

@gerardcl gerardcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@braisvq1996
Copy link
Contributor

@cschweikert It has conflicts in Changelog

gerardcl
gerardcl approved these changes Apr 7, 2022
View reviewed changes
Copy link
Member

@gerardcl gerardcl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@cschweikert cschweikert merged commit ddd878e into master Apr 7, 2022
@cschweikert cschweikert mentioned this pull request Apr 7, 2022
Merged
2 tasks
@cschweikert cschweikert deleted the move-qs-to-nodejs-16 branch April 8, 2022 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerardcl gerardcl gerardcl approved these changes

@netzartist netzartist Awaiting requested review from netzartist

@ManuelFeller ManuelFeller Awaiting requested review from ManuelFeller

@bljubisic bljubisic Awaiting requested review from bljubisic bljubisic is a code owner

@sino92 sino92 Awaiting requested review from sino92 sino92 is a code owner

@braisvq1996 braisvq1996 Awaiting requested review from braisvq1996

Assignees

@cschweikert cschweikert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nodejs 12 EOL in April
3 participants
@cschweikert @braisvq1996 @gerardcl