Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update and improve e2e-cypress (master) #771

Merged
merged 1 commit into from Apr 7, 2022
Merged

Conversation

cschweikert
Copy link
Member

@cschweikert cschweikert commented Mar 31, 2022

The following things in the current e2e-cypress quickstarter have been updated, added or improved:

  • cypress: 7.5.0 -> 9.5.3
  • typescript: 4.3.2 -> 4.6.3
  • switch to new Node.js 16 build agent
  • instead of precompiling TypeScript code it is possible to make use Cypress' native support for TypeScript
  • improve the structure of the example code (login commands)
  • provide recipes for get around post-installation of Cypress' binaries
  • bring documentation up-to-speed
  • tslint is deprecated -> removal of linting support and hint about eslint and prettier

Fixes #770

Tasks:

  • Updated documentation in docs/modules/... directory
  • Ran tests in <quickstarter>/testdata directory

Please note

  1. I took ownership for e2e-cypress. I also talked with @tbabik and removed him from CODEOWNERS

  2. The support for TSLint was removed from this quickstarter. Please consider adding ESLint support or a formatter like Prettier.

  3. This quickstarter already uses version 16 of the nodeJS-based build agent. An update of this version is done in Nodejs 12 EOL in April #763 and need to be merged first. Nevertheless it is successfully tested with version 16.

  4. The unit testing capabilities are currently broken (see for exmple Quickstarter tests: Verifying Jenkins run attachments fails ods-core#1124 and Provisioning of projects doesn't setup Jenkins with Aqua credentials  ods-core#1125). I filled the gaps as good as I could with manual tests.

  5. There will be a follow-up PR for the 4.x branch.

@cschweikert
Copy link
Member Author

The native TypeScript support of Cypress reminded me to the disussion we had earlier today 😉

Copy link
Contributor

@m-apsolon m-apsolon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tbabik is our colleague, imo you could also share ownership; otherwise, looks good to me.

@tbabik
Copy link

tbabik commented Apr 4, 2022

@m-apsolon @cschweikert I'm all good with transfering ownership. Had a quick chat with Christian on Friday about it. Thanks!

@cschweikert
Copy link
Member Author

@m-apsolon Yeah, sry for the confusion.

@cschweikert cschweikert merged commit a8f55fc into master Apr 7, 2022
@cschweikert cschweikert deleted the update-e2e-cypress branch April 8, 2022 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update and renew e2e-cypress
3 participants