Update and improve e2e-cypress (master) #771
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The following things in the current e2e-cypress quickstarter have been updated, added or improved:
Fixes #770
Tasks:
docs/modules/...
directory<quickstarter>/testdata
directoryPlease note
I took ownership for e2e-cypress. I also talked with @tbabik and removed him from
CODEOWNERS
The support for TSLint was removed from this quickstarter. Please consider adding ESLint support or a formatter like Prettier.
This quickstarter already uses version 16 of the nodeJS-based build agent. An update of this version is done in Nodejs 12 EOL in April #763 and need to be merged first. Nevertheless it is successfully tested with version 16.
The unit testing capabilities are currently broken (see for exmple Quickstarter tests: Verifying Jenkins run attachments fails ods-core#1124 and Provisioning of projects doesn't setup Jenkins with Aqua credentials ods-core#1125). I filled the gaps as good as I could with manual tests.
There will be a follow-up PR for the
4.x
branch.