Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ionic quickstarter #1009

Merged
merged 5 commits into from May 20, 2024
Merged

Update ionic quickstarter #1009

merged 5 commits into from May 20, 2024

Conversation

josueggh
Copy link
Contributor

@josueggh josueggh commented Apr 23, 2024 •
edited by braisvq1996

Update of ionic quickstarter to version 7.2.0 and nodejs 22

bljubisic
bljubisic previously approved these changes Apr 23, 2024
View reviewed changes
@josueggh josueggh changed the title Update ionic quikcstarter Update ionic quickstarter May 16, 2024
@braisvq1996 braisvq1996 self-requested a review May 16, 2024 11:49
braisvq1996
braisvq1996 previously approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@braisvq1996 braisvq1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quickstarter golden test successfully completed

@braisvq1996
Copy link
Contributor

@bljubisic if you are ok with this changes we will merge it and add in for the next release

bljubisic
bljubisic previously approved these changes May 20, 2024
View reviewed changes
braisvq1996
braisvq1996 reviewed May 20, 2024
View reviewed changes
Copy link
Contributor

@braisvq1996 braisvq1996 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just in a conversation with some colleagues about this topic and it would be better if we also update this to use nodejs 22 agent.

Later on I will do a quick tests and update this PR accordingly

@braisvq1996 braisvq1996 dismissed stale reviews from bljubisic and themself via 266293a May 20, 2024 12:10
braisvq1996
braisvq1996 previously approved these changes May 20, 2024
View reviewed changes
@braisvq1996 braisvq1996 merged commit d979506 into opendevstack:master May 20, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@braisvq1996 braisvq1996 braisvq1996 approved these changes

@bljubisic bljubisic bljubisic left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@josueggh @braisvq1996 @bljubisic