Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FW: Log a failure to set the CPU affinity as a platform problem #67

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

thiagomacieira
Copy link
Contributor

It's not fatal, but it's bad. I thought about simply refusing to run,
but some tests will deadlock if not all threads get run, in which case
we'd compound the problem.

Removed the perror() calls.

This will produce logs like:

  - thread: main
    messages:
    - { level: warning, text: 'W> Platform issue: Failed to set affinity to CPU 10 (logical CPU 10): Invalid argument' }
  - thread: 10
    id: { logical: 10, package: 0, core: 11, thread: 0, family: 6, model: 0x55, stepping: 4, microcode: 0x2006c0a, ppin: null }
    loop-count: 0
    messages:
    - { level: warning, text: 'W> Setting CPU affinity failed, content is likely not running on CPU 10 (logical CPU 10)' }

Signed-off-by: Thiago Macieira thiago.macieira@intel.com

@thiagomacieira thiagomacieira force-pushed the FW_Log_a_failure_to_set_the_CPU_affinity_as_a_platform_problem branch from 5ee9ec0 to d8998cb Compare March 22, 2022 15:09
It's not fatal, but it's bad. I thought about simply refusing to run,
but some tests will deadlock if not all threads get run, in which case
we'd compound the problem.

Removed the perror() calls.

Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
Copy link
Contributor

@thac0 thac0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W00t. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants