Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/simplify test management #495

Open
wants to merge 12 commits into
base: main
Choose a base branch
from
Open

Refactor/simplify test management #495

wants to merge 12 commits into from

Commits on May 24, 2024

  1. Remove the entire test_selectors code. 

    The framework is broken, but clean of what we will be getting rid of.

Signed-off-by: Arzhan Kinzhalin <arzhan.i.kinzhalin@intel.com>
    @busykai
    busykai committed May 24, 2024
    Configuration menu
    Copy the full SHA
    1e6ba4e View commit details
    Browse the repository at this point in the history

  2. FW: Refactor test management. 

    Signed-off-by: Arzhan Kinzhalin <arzhan.i.kinzhalin@intel.com>
    @busykai
    busykai committed May 24, 2024
    Configuration menu
    Copy the full SHA
    e768be2 View commit details
    Browse the repository at this point in the history

  3. FW: Test mgmt refactor: Add support for test lists. 

    Signed-off-by: Arzhan Kinzhalin <arzhan.i.kinzhalin@intel.com>
    @busykai
    busykai committed May 24, 2024
    Configuration menu
    Copy the full SHA
    4d8ac85 View commit details
    Browse the repository at this point in the history

  4. FW: Test mgmt refactor: Configure TestSet when creating. 

    Signed-off-by: Arzhan Kinzhalin <arzhan.i.kinzhalin@intel.com>
    @busykai
    busykai committed May 24, 2024
    Configuration menu
    Copy the full SHA
    f3952c2 View commit details
    Browse the repository at this point in the history

  5. FW: Test mgmt refactor: Implement randomness and infinite iterator. 

    This is to support --test-list-randomize and various timing options when
OpenDCDiag cycles through the list.

Signed-off-by: Arzhan Kinzhalin <arzhan.i.kinzhalin@intel.com>
    @busykai
    busykai committed May 24, 2024
    Configuration menu
    Copy the full SHA
    f95cb43 View commit details
    Browse the repository at this point in the history

  6. FW: Test mgmt refactor: Use global state to keep the test count. 

    Signed-off-by: Arzhan Kinzhalin <arzhan.i.kinzhalin@intel.com>
    @busykai
    busykai committed May 24, 2024
    Configuration menu
    Copy the full SHA
    3e1bb3a View commit details
    Browse the repository at this point in the history

  7. FW: Test mgmt refactor: Refactor how SMI accounting is done. 

    Instead of reinitializing SMI counts every "loop" of the test, it's done
after smi_count test has been run (in its clean up).

Signed-off-by: Arzhan Kinzhalin <arzhan.i.kinzhalin@intel.com>
    @busykai
    busykai committed May 24, 2024
    Configuration menu
    Copy the full SHA
    a7834cc View commit details
    Browse the repository at this point in the history

  8. FW: Test mgmt refactor: BATS: Expect ok mce_check. 

    Previously it was not "injected" at the very end if there were failured,
but it was injected inbetween regardless. With the new implementation it
is consistently run at the end of each iteration.

Signed-off-by: Arzhan Kinzhalin <arzhan.i.kinzhalin@intel.com>
    @busykai
    busykai committed May 24, 2024
    Configuration menu
    Copy the full SHA
    b5b3897 View commit details
    Browse the repository at this point in the history

  9. FW: Test mgmt refactor: Get rid of RESTART_OF_TESTS. 

    The mce_test (mce_check) is now added to the end of the test_set. The
logic of SandstoneTestSet will keep it last on the list. It will be
therefore run each iteration.

Code that resets the count on new iteration as well as printing of the
header is moved to the iterator instead of main cycle.

Signed-off-by: Arzhan Kinzhalin <arzhan.i.kinzhalin@intel.com>
    @busykai
    busykai committed May 24, 2024
    Configuration menu
    Copy the full SHA
    86e5a5d View commit details
    Browse the repository at this point in the history

  10. FW: Test mgmt refactor: Add support for builtin test lists. 

    Signed-off-by: Arzhan Kinzhalin <arzhan.i.kinzhalin@intel.com>
    @busykai
    busykai committed May 24, 2024
    Configuration menu
    Copy the full SHA
    17bcd6f View commit details
    Browse the repository at this point in the history

  11. FW: Test mgmt refactor: Separate test list and lifecycle management. 

    Signed-off-by: Arzhan Kinzhalin <arzhan.i.kinzhalin@intel.com>
    @busykai
    busykai committed May 24, 2024
    Configuration menu
    Copy the full SHA
    647801e View commit details
    Browse the repository at this point in the history

  12. BATS: Use selftest_sigill instead of selftest_sigkill. 

    selftest_sigkill is not a valid test name on Windows. After the
refactoring opendcdiag.exe produces an empty output when an illegal test
name is specified. Before it was not touching the log file, but the test
was failing cause it was reading the output.yaml of the previous run
(note the loop over tests).

Also, make the output file unique.

Signed-off-by: Arzhan Kinzhalin <arzhan.i.kinzhalin@intel.com>
    @busykai
    busykai committed May 24, 2024
    Configuration menu
    Copy the full SHA
    c73dc66 View commit details
    Browse the repository at this point in the history