FW/child_debug: use std::string more #488
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the dumping the processor context, this removes
open_memstream()
on Unix systems and more importantly, removes the need for an actual temporary file on Windows.For the gdb communication, we were using a plain file descriptor because that allowed us to use
splice()
straight from the pipe to the backing file, in case the backtrace was big. But that's really unnecessary and was a source of bugs because the non-Linux code was never tested. It's now replaced with directstd::string
and moved up the location where we call the logging functions to outside of the GDB communication loop.And doing the same for the communication with
ps
, which allows us to remove theLoggingStream
class.