FW/child_debug: use std::string #482
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So we can use it where no formatting is needed elsewhere in the framework. Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
This removes `open_memstream()` on Unix systems and more importantly, removes the need for an actual temporary file on Windows. Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
We were using a plain file descriptor because that allowed us to use `splice()` straight from the pipe to the backing file, in case the backtrace was big. But that's really unnecessary and was a source of bugs because the non-Linux code was never tested. Replace with direct std::string and move up the location where we call the logging functions to outside of the GDB communication loop. Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
This removes the last user of LoggingStream. Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
All its uses have been replaced with `log_message_preformatted()`. That's slighty less efficient because we must read into our own buffers before writing to the log file, something we are going to do anyway. But it simplifies the codebase and reduces the number of system calls. Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes both the Unix and Windows child-debuggers to use
std::stringmore instead of writing to file descriptors. This should improve performance a bit because we don't make system calls to store our content as it's being built. It also allows us to remove theLoggingStreamclass (was added in #286's 040bc36 to replace theFILE *-based API).Using the API added in #479, this removes
open_memstream()on Unix systems and more importantly, removes the need for an actual temporary file on Windows.