Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix test listing behavior and enabling/disabling tests #227

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix test listing behavior and enabling/disabling tests #227

wants to merge 2 commits into from

Commits on May 26, 2023

  1. FW: Fix an issue with test listing. 

    The tests listing (options -l, --list-tests, --list-groups) are not
taking into account the set of tests specified on the command line,
either test list, built in tests list, or --enable/--disable options.

Before any option modifying the actual test list were ignored by the
list options. With this change, the actual tests that would be executed
are listed. However, the default behavior of 'opendcdiag -l' stays the
same.

Some examples illustrating the new behavior:

$ ./builddir/opendcdiag -vv -l -e eigen_svd -e zstd1
1 eigen_svd            "Eigen SVD (Singular Value Decomposition) solving payload, which issues a bunch of matrix multiplies underneath"
2 zstd1                "ZStandard compression test - ZStandard compression and decompression with random data (level 1)"

Groups:
@Compression           "Tests that drive compression routines in various libraries"
  zstd1
@math                  "Tests that perform math using, e.g., Eigen"
  eigen_svd
$ ./builddir/opendcdiag -vv -l -e eigen_svd -e zstd1 --disable=zstd1
1 eigen_svd            "Eigen SVD (Singular Value Decomposition) solving payload, which issues a bunch of matrix multiplies underneath"

Groups:
@Compression           "Tests that drive compression routines in various libraries"
@math                  "Tests that perform math using, e.g., Eigen"
  eigen_svd
$ cat testlist
eigen_svd
zstd1
$ ./builddir/opendcdiag -vv -l --test-list-file=testlist
1 eigen_svd            "Eigen SVD (Singular Value Decomposition) solving payload, which issues a bunch of matrix multiplies underneath"
2 zstd1                "ZStandard compression test - ZStandard compression and decompression with random data (level 1)"

Groups:
@Compression           "Tests that drive compression routines in various libraries"
  zstd1
@math                  "Tests that perform math using, e.g., Eigen"
  eigen_svd
$ ./builddir/opendcdiag -vv -l --test-list-file=testlist --disable=eigen_svd
1 zstd1                "ZStandard compression test - ZStandard compression and decompression with random data (level 1)"

Groups:
@Compression           "Tests that drive compression routines in various libraries"
  zstd1

Signed-off-by: Arzhan Kinzhalin <arzhan.i.kinzhalin@intel.com>
    @busykai
    busykai committed May 26, 2023
    Configuration menu
    Copy the full SHA
    076ce4d View commit details
    Browse the repository at this point in the history

  2. FW: Do not execute tests that were disabled. 

    Or tests that were specified on the command line (either via -e or a test
list), but that are lower quality than requested.

Fixes #213.

Signed-off-by: Arzhan Kinzhalin <arzhan.i.kinzhalin@intel.com>
    @busykai
    busykai committed May 26, 2023
    Configuration menu
    Copy the full SHA
    0e26eed View commit details
    Browse the repository at this point in the history