FW/logging: refactor log_{platform_,}message #154
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Didn't work. |
thiagomacieira
force-pushed
the
fix-log-platform-message-race
branch
from
e911dcb
to
958c7cd
Compare
thiagomacieira
changed the title
Our logging FILE* are opened in unbuffered mode. Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
log_data() is probably only used by tests, so there's no race problem there. But log_message() may be used on the main thread's messaging, which could cause a race condition. Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
This merges the two functions for the most part and makes them use a single writev() call to write the content. This was originally done to fix opendcdiag#153, but that fails because the Linux kernel does not guarantee atomicity of write() calls and I wouldn't care to make a guess what other OSes do. If we want to have log_platform_message() be thread-safe, we'll need to insert a mutex. Signed-off-by: Thiago Macieira <thiago.macieira@intel.com>
thiagomacieira
force-pushed
the
fix-log-platform-message-race
branch
from
958c7cd
to
f3e920f
Compare
lukasz-tuz
approved these changes
May 8, 2024
|
This is old code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merges the two functions for the most part and makes them use a single
writev()call to write the content.This was originally done to fix #153, but that fails because the Linux kernel does not guarantee atomicity of write() calls and I wouldn't care to make a guess what other OSes do. If we want to have
log_platform_message()be thread-safe, we'll need to insert a mutex.Signed-off-by: Thiago Macieira thiago.macieira@intel.com