Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] fw: remove --max-test-count #106

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

[RFC] fw: remove --max-test-count #106

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
9 changes: 0 additions & 9 deletions framework/sandstone.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -127,7 +127,6 @@ enum {
test_knob_option,
longer_runtime_option,
max_concurrent_threads_option,
max_test_count_option,
max_test_loop_count_option,
max_messages_option,
max_logdata_option,
Expand Down Expand Up @@ -2850,7 +2849,6 @@ int main(int argc, char **argv)
{ "list-groups", no_argument, nullptr, raw_list_groups },
{ "longer-runtime", required_argument, nullptr, longer_runtime_option },
{ "max-concurrent-threads", required_argument, nullptr, max_concurrent_threads_option },
{ "max-test-count", required_argument, nullptr, max_test_count_option },
{ "max-test-loop-count", required_argument, nullptr, max_test_loop_count_option },
{ "mce-check-every", required_argument, nullptr, mce_check_period_option },
{ "max-logdata", required_argument, nullptr, max_logdata_option },
Expand Down Expand Up @@ -3268,10 +3266,6 @@ int main(int argc, char **argv)
sApp->endtime = calculate_wallclock_deadline(5min, &sApp->starttime);
break;

case max_test_count_option:
sApp->max_test_count = ParseIntArgument<>{"--max-test-count"}();
break;

case max_test_loop_count_option:
sApp->max_test_loop_count = ParseIntArgument<>{"--max-test-loop-count"}();
if (sApp->max_test_loop_count == 0)
Expand Down Expand Up @@ -3440,9 +3434,6 @@ int main(int argc, char **argv)
triage_tests.push_back(test);
}

if (total_tests_run >= sApp->max_test_count)
break;

//don't wait when the test failed or it was skipped.
if(sApp->service_background_scan == true && (r != TestFailed || r != TestSkipped))
background_scan_wait();
Expand Down
1 change: 0 additions & 1 deletion framework/sandstone_p.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,7 +320,6 @@ struct SandstoneApplication : public InterruptMonitor, public test_the_test_data
static constexpr int MaxRetestCount = 64;
int retest_count = 10;
int total_retest_count = -2;
int max_test_count = INT_MAX;
int max_test_loop_count = 0;
int max_concurrent_thread_count = 0;
int current_max_loop_count;
Expand Down