Fix dark theme rtd styling #1579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 17, 2024 07:34
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1579 +/- ##
========================================
Coverage 91.79% 91.79%
========================================
Files 132 132
Lines 14633 14633
========================================
Hits 13432 13432
Misses 1201 1201 ☔ View full report in Codecov by Sentry. |
SpacemanPaul
approved these changes
Apr 17, 2024
SpacemanPaul
added a commit
that referenced
this pull request
Apr 18, 2024
* Update whats_new.rst for 1.8.18 release. (#1568) * Update whats_new.rst for 1.8.18 release. * Update PR number * Add missing PR. * Merge pull request #1579 from opendatacube/fix_dark_theme Fix dark theme rtd styling * update whats_new --------- Co-authored-by: Paul Haesler <linkjuggler@gmail.com> Co-authored-by: Ariana Barzinpour <ariana.barzinpour@ga.gov.au>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this pull request
Readthedocs dark theme styling only changes the colour for some elements, making text difficult to read.
Proposed changes
Update css theme colours for when dark mode is selected
Closes Low contrast text on 1.9 migration page when using dark mode #1576
Tests added / passed
Fully documented, including
docs/about/whats_new.rstfor all changes📚 Documentation preview 📚: https://datacube-core--1579.org.readthedocs.build/en/1579/