Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: fix typos #1577

Merged
merged 2 commits into from Apr 17, 2024
Merged

docs: fix typos #1577

merged 2 commits into from Apr 17, 2024

Conversation

pjonsson
Copy link

@pjonsson pjonsson commented Apr 16, 2024

Reason for this pull request

Fix typos in the docs.

Proposed changes

  • Closes #xxxx
  • Tests added / passed
  • Fully documented, including docs/about/whats_new.rst for all changes

@SpacemanPaul
Copy link
Contributor

Thanks Peter.

Happy to merge this, but could you please:

  1. Combine the change in configuration.rst: align comment and code #1578 into this PR; and
  2. Add a line to the "1.9.next" section of docs/about/whats_new.rst describing the PR.

Copy link

codecov bot commented Apr 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.80%. Comparing base (93e1d01) to head (44fe10c).

❗ Current head 44fe10c differs from pull request most recent head b8856f2. Consider uploading reports for the commit b8856f2 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##           develop-1.9    #1577   +/-   ##
============================================
  Coverage        85.80%   85.80%           
============================================
  Files              140      140           
  Lines            15402    15402           
============================================
  Hits             13215    13215           
  Misses            2187     2187           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SpacemanPaul SpacemanPaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment above - please combine with your other documentation PR and add a line to doc/about/whats_new.rst

Copy link
Contributor

@SpacemanPaul SpacemanPaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Peter!

@SpacemanPaul SpacemanPaul merged commit c0e4b89 into opendatacube:develop-1.9 Apr 17, 2024
3 checks passed
@pjonsson pjonsson deleted the fix-typos branch April 18, 2024 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants