Refine default behaviour of config engine to support easier migration from 1.8 #1573
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reason for this pull request
Previously when:
default
ordatacube
environment); and$DB_*
environment variables; anda
ConfigException
was raised.This is a very common scenario in existing 1.8.x ODC applications, and throwing an error is unexpected behaviour that makes migration from 1.8 to 1.9 more complex than it needs to be.
Proposed changes
When:
default
ordatacube
environment); andThe environment now defaults to
default
on the assumption that configuration will be available in the next step via environment variables.docs/about/whats_new.rst
for all changes