Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TYPE: Standardize resampling type #1571

Merged
merged 1 commit into from Apr 2, 2024

Conversation

snowman2
Copy link
Contributor

@snowman2 snowman2 commented Apr 1, 2024

Reason for this pull request

Identified some inconsistent support for Resampling types.

Proposed changes

  • Standardize resampling input supported to odc.geo.warp.Resampling.

  • Tests added / passed

  • Fully documented, including docs/about/whats_new.rst for all changes

Guidance on testing you would like to see added is welcome.

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 85.58%. Comparing base (2a4aefe) to head (36489cb).

Files Patch % Lines
datacube/utils/cog.py 75.00% 1 Missing ⚠️
Additional details and impacted files
@@               Coverage Diff               @@
##           develop-1.9    #1571      +/-   ##
===============================================
- Coverage        85.59%   85.58%   -0.01%     
===============================================
  Files              140      140              
  Lines            15379    15384       +5     
===============================================
+ Hits             13163    13167       +4     
- Misses            2216     2217       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SpacemanPaul SpacemanPaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @snowman2

@SpacemanPaul SpacemanPaul merged commit 9561764 into opendatacube:develop-1.9 Apr 2, 2024
17 checks passed
@snowman2
Copy link
Contributor Author

snowman2 commented Apr 2, 2024

Thank you 👍

@snowman2 snowman2 deleted the resampling branch April 2, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants