New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refine _time_to_search_dims logic #1561
Conversation
…ed as an int/float is the same as when it is a string
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1561 +/- ##
========================================
Coverage 91.78% 91.78%
========================================
Files 132 132
Lines 14641 14621 -20
========================================
- Hits 13438 13420 -18
+ Misses 1203 1201 -2 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks.
Co-authored-by: Damien Ayers <damien@omad.net>
Reason for this pull request
Passing
time
as an int/float todc.load
was causing the query to return an unexpected date range due to the value being interpreted as seconds since epoch. Int/float is not documented as an accepted type fortime
in the first place and could be ambiguous.Proposed changes
Raise error if time is not provided as some form of datetime or a string
Tweak and consolidate logic in
_time_to_search_dims
and_to_datetime
Remove added millisecond in time range from
like
as it appears unnecessaryCloses #xxxx
Tests added / passed
Fully documented, including
docs/about/whats_new.rst
for all changes📚 Documentation preview 📚: https://datacube-core--1561.org.readthedocs.build/en/1561/