Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update windows setup instructions #1526

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

Conversation

Ariana-B
Copy link
Contributor

@Ariana-B Ariana-B commented Dec 22, 2023

Reason for this pull request

Windows developer setup instructions are out of date and incomplete.

Proposed changes

  • Update windows setup guide to be more complete

  • Closes #xxxx

  • Tests added / passed

  • Fully documented, including docs/about/whats_new.rst for all changes


📚 Documentation preview 📚: https://datacube-core--1526.org.readthedocs.build/en/1526/

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (9fb8c8c) 91.75% compared to head (f393c36) 91.79%.
Report is 5 commits behind head on develop.

Files Patch % Lines
datacube/index/memory/_datasets.py 80.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1526      +/-   ##
===========================================
+ Coverage    91.75%   91.79%   +0.04%     
===========================================
  Files          132      132              
  Lines        14552    14624      +72     
===========================================
+ Hits         13352    13424      +72     
  Misses        1200     1200              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@SpacemanPaul SpacemanPaul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should be telling them to git clone or run the integration tests here.

Just tell them the bare minimum they need to get a conda environment working on windows - with datacube coming from PIP or Condaforge.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants