Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli maturity model #1449

Closed
wants to merge 39 commits into from
Closed

cli maturity model #1449

wants to merge 39 commits into from

Conversation

Ariana-B
Copy link
Contributor

@Ariana-B Ariana-B commented May 25, 2023

Reason for this pull request

#1444

Proposed changes

@Ariana-B Ariana-B changed the base branch from develop to develop-1.9 May 25, 2023 07:05
@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Patch coverage: 93.76% and project coverage change: -6.19 ⚠️

Comparison is base (032265a) 91.82% compared to head (0e9742e) 85.64%.

❗ Current head 0e9742e differs from pull request most recent head b5d17d9. Consider uploading reports for the commit b5d17d9 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1449      +/-   ##
===========================================
- Coverage    91.82%   85.64%   -6.19%     
===========================================
  Files          132      134       +2     
  Lines        14485    14982     +497     
===========================================
- Hits         13301    12831     -470     
- Misses        1184     2151     +967     
Impacted Files Coverage Δ
datacube/config.py 97.61% <ø> (ø)
datacube/drivers/netcdf/_write.py 100.00% <ø> (ø)
datacube/model/properties.py 66.41% <ø> (+0.49%) ⬆️
datacube/utils/__init__.py 100.00% <ø> (ø)
datacube/utils/_misc.py 82.35% <70.00%> (-17.65%) ⬇️
datacube/index/postgres/_datasets.py 94.38% <71.42%> (-0.46%) ⬇️
datacube/index/memory/_datasets.py 88.86% <79.31%> (-0.63%) ⬇️
datacube/api/query.py 93.75% <83.33%> (-0.09%) ⬇️
datacube/index/null/index.py 92.42% <83.33%> (-1.13%) ⬇️
datacube/index/postgis/_datasets.py 75.17% <85.71%> (+0.35%) ⬆️
... and 43 more

... and 10 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

SpacemanPaul and others added 26 commits May 30, 2023 02:30
* Add new index "supports" flag for external lineage.

* Postgis schema for new Lineage implementation.

* Lineage tree model.

* source and derived tree properties for Dataset model.

* More lineage work - NOT STABLE!

* Fix typo.

* Fix incomplete kwargs to resolve_legacy_lineage.

* Get tests passing.

* Extend support validation tests.

* Update PK for lineage table

* Update lineage API.

* Fix import

* BatchStatus comment to docstring

* Existing tests passing - ie. mostly typos.

* Some lineage tests. TODO: cyclic dependency detection.

* More fixes and tests - currently UNSTABLE.

* Docstrings and tests.

* flake8 etc.

* More flake8/lintage.

* Update hl after minor lineage API change.

* Rethink hl API based on experience implementing lineage models.

* Fix dataset_resolver()

* Fix hl validation and tests.

* More hl test coverage.

* Lineage API coverage, and fixes to relations_diff()

* flake8age.

* More test coverage.

* flake8age.

* More test coverage.

* Fix bad indentation - thanks flake8.

* I think that must be nearly 100% coverage of lineage.py

* Default (non-implementation) of LineageResource in most drivers.  Stubs for postgis impl.

* Postgis implementation of lineage home api.

* Postgis implementation of lineage home api.

* Add home-reading API, more tests and lint-fixes.

* Flake8 over aesthetics.

* Lineage API implemented - not tested, probably broken.

* Some basic tests. Make sense of relation pairs consistent.  (i.e. fix mutually-cancelling-out bugs)

* Tests, cleanup and bugfixes.

* flake8age

* Oops - debugger was still enabled.

* More test coverage.

* More test coverage of postgis driver.

* Don't delete lineage with datasets.

* Implement lineage.remove() and tests.

* Cleanup internal APIs.

* flake8age

* flake8age

* LineageTree serialisation/deserialisation methods.

* flake8age

* docstrings for postgis.drivers._api

* More docstrings and inline comments.

* Added comments to explain bad diamond test.
@Ariana-B Ariana-B changed the base branch from develop-1.9 to develop May 30, 2023 04:41
@Ariana-B Ariana-B closed this May 30, 2023
@Ariana-B Ariana-B deleted the cli_maturity_model branch May 30, 2023 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement the maturity model for the datacube cmd interface
2 participants