Cleanup #1406
Cleanup #1406
Conversation
|
All looks good on a quick glance. Will review properly when it's ready - thanks for all this, Ariana. |
Ariana-B
force-pushed
the
cleanup_and_deprecation_warnings
branch
from
c59b138
to
bf1faf3
Compare
datacube/model/__init__.py
Outdated
| @@ -21,9 +21,11 @@ | |||
| schema_validated, DocReader | |||
| from datacube.index.eo3 import is_doc_eo3 | |||
| from .fields import Field, get_dataset_fields | |||
| from ._base import Range, ranges_overlap # noqa: F401 | |||
| from ._base import Range | |||
There was a problem hiding this comment.
I think ranges_overlap is here so you can from datacube.model import ranges_overlap.
You can get rid of the flake8 ignore by defining an __all__
datacube/utils/documents.py
Outdated
| except (AttributeError, KeyError, ValueError): | ||
| continue | ||
| return fields | ||
| return {name: field.extract(self.doc) |
There was a problem hiding this comment.
Are there implications for not catching those errors? It feels like a risky thing to move, but it seems things would have to be pretty broken elsewhere for any of those errors to occur.
There was a problem hiding this comment.
There'd have to be a mismatch between the MetadataType definition and the Dataset's metadata document. If that doesn't already cause other problems elsewhere, it might be better to throw an exception or at least log a warning instead of letting it silently slip past.
Ariana-B
force-pushed
the
cleanup_and_deprecation_warnings
branch
from
41285d6
to
d8e8057
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## develop-1.9 #1406 +/- ##
===============================================
+ Coverage 91.95% 91.97% +0.01%
===============================================
Files 135 135
Lines 15085 15070 -15
===============================================
- Hits 13872 13860 -12
+ Misses 1213 1210 -3
☔ View full report in Codecov by Sentry. |
Reason for this pull request
The datacube-core code could use some cleanup. I'm starting off with some small/easy wins, primarily focused on removing/consolidating duplicated logic and making code more pythonic and concise.
Proposed changes
Merged
get_doc_offsetandget_doc_offset_safePrettified DocReader properties, and added
docattributeAdded a few deprecation warnings with the deprecat library
Closes #xxxx
Tests added / passed
Fully documented, including
docs/about/whats_new.rstfor all changes📚 Documentation preview 📚: https://datacube-core--1406.org.readthedocs.build/en/1406/