Go directly to rasterio.DatasetReader instead of rasterio.open #1008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`rasterio.open` tries to be smart about environment setup even if user didn't activate environment, it also deals with ro vs rw modes. Since we always open in ro mode and always activate credentialed environment we can skip directly to DatasetReader class and avoid credentialization bugs in rasterio.
Codecov Report
@@ Coverage Diff @@
## develop #1008 +/- ##
========================================
Coverage 93.02% 93.02%
========================================
Files 96 96
Lines 9792 9793 +1
========================================
+ Hits 9109 9110 +1
Misses 683 683
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rasterio.opentries to be smart about environment setup even if user didn'tactivate environment, it also deals with ro vs rw modes. Since we always open in
ro mode and always activate credentialed environment we can skip directly to
DatasetReader class and avoid credentialization bugs in rasterio.
Reason for this pull request
major slow-down in sandbox are caused by rasterio misguided attempts at credentialization on every file open even when public reads are enabled.
GeoscienceAustralia/dea-sandbox#121
docs/about/whats_new.rstfor all changes