Refine default behaviour of config engine to support easier migration…

… from 1.8
opendatacube · Apr 9, 2024 · b283878 · b283878
1 parent 9561764
commit b283878
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 4 deletions.
diff --git a/datacube/cfg/api.py b/datacube/cfg/api.py
@@ -220,7 +220,9 @@ def __getitem__(self, item: str | None) -> "ODCEnvironment":
                               "this fallback behaviour is deprecated and may change in a future release.")
                 item = "datacube"
             else:
-                raise ConfigException("No environment specified and no default environment could be identified.")
+                # No explicitly defined (known) environments - assume default and hope there's config
+                # available in environment variables.
+                item = "default"
         if item not in self.known_environments:
             self.known_environments[item] = ODCEnvironment(self, item, {}, True)
         return self.known_environments[item]

diff --git a/docs/about/whats_new.rst b/docs/about/whats_new.rst
@@ -8,7 +8,8 @@ What's New
 v1.9.next
 =========
 
-- Standardize resampling input supported to `odc.geo.warp.Resampling`.
+- Standardize resampling input supported to `odc.geo.warp.Resampling` (:pull:`1571`)
+- Refine default behaviour for config engine to support easier migration from 1.8 (:pull:`1573`)
 
 
 v1.9.0-rc3 (27th March 2024)

diff --git a/tests/test_cfg.py b/tests/test_cfg.py
@@ -542,5 +542,4 @@ def test_default_environment(simple_config, monkeypatch):
         'weirdname': {"index_driver": "memory"},
         'stupidenv': {"index_driver": "null"},
     })
-    with pytest.raises(ConfigException):
-        cfg[None]._name
+    assert cfg[None]._name == "default"