Add a couple more arg types and tidy imports in tests

datacube/model/__init__.py

@@ -513,6 +513,10 @@ class CRS(object):
     """
 
     def __init__(self, crs_str):
+        """
+
+        :param crs_str: string representation of a CRS, often an EPSG code like 'EPSG:4326'
+        """
         if isinstance(crs_str, CRS):
             crs_str = crs_str.crs_str
         self.crs_str = crs_str

datacube/storage/storage.py

@@ -268,6 +268,13 @@ def whats_my_transform(self, src):
 def create_netcdf_storage_unit(filename,
                                crs, coordinates, variables, variable_params, global_attributes=None,
                                netcdfparams=None):
+    """
+    Create a NetCDF file on disk.
+
+    :param pathlib.Path filename: filename to write to
+    :param datacube.model.CRS crs: Datacube CRS object defining the spatial projection
+    :return: open netCDF4.Dataset object
+    """
     if filename.exists():
         raise RuntimeError('Storage Unit already exists: %s' % filename)
 

tests/storage/test_netcdfwriter.py

@@ -4,7 +4,6 @@
 
 import netCDF4
 import numpy
-from osgeo import osr
 
 from datacube.model import Variable, CRS
 from datacube.storage.netcdf_writer import create_netcdf, create_coordinate, create_variable, netcdfy_data, \

tests/storage/test_storage.py

@@ -17,7 +17,6 @@
 
 import numpy
 import netCDF4
-from pathlib import Path
 from affine import Affine
 import xarray