Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CMakeLists.txt to support static linking to HDF5 #3563

Open
wants to merge 1 commit into
base: 4.x
Choose a base branch
from

Conversation

CSBVision
Copy link

Proposal to fix #3560.
In particular, the required library to fix the linker error while statically linking to HDF5 is included. Besides this, HDF5 might also depend on ZLIB. For this reasoning, it will be added to the dependent libraries (if available).
In this way, the same ZLIB build can be shared between OpenCV and HDF5 by first compiling ZLIB and, thereafter, use it for OpenCV using BUILD_ZLIB=False, ZLIB_INCLUDE_DIR and ZLIB_LIBRARY_RELEASE CMake flags. If HDF5 is linked dynamically, nothing changes.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Statically linking to HDF5 library raises linker errors
1 participant