Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add smoother and test #54

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

add smoother and test #54

wants to merge 4 commits into from

Conversation

peterdudfield
Copy link
Contributor

Pull Request

Description

Smooth results from models. This make less spiky results. This is because he models don't know about each other.

Fixes #

How Has This Been Tested?

Added a test

  • Yes

Checklist:

  • My code follows OCF's coding style guidelines
  • I have performed a self-review of my own code
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I have checked my code and corrected any misspellings

@peterdudfield peterdudfield self-assigned this Mar 30, 2023
@codecov
Copy link

codecov bot commented Mar 30, 2023

Codecov Report

Merging #54 (4130e83) into main (df2a642) will increase coverage by 0.39%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
+ Coverage   43.05%   43.45%   +0.39%     
==========================================
  Files          21       21              
  Lines         950      962      +12     
==========================================
+ Hits          409      418       +9     
- Misses        541      544       +3     
Impacted Files Coverage Δ
gradboost_pv/app.py 0.00% <0.00%> (ø)
gradboost_pv/__init__.py 100.00% <100.00%> (ø)
gradboost_pv/inference/utils.py 97.22% <100.00%> (+0.92%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@peterdudfield
Copy link
Contributor Author

Hold fire on this, until we see jagged results again. The results are a bite smoother right now as we interpolate to 30 mins for each run of the forecast

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: No status
Development

Successfully merging this pull request may close these issues.

None yet

1 participant